Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.3] Backports for January CPU release #638

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Dec 18, 2023

Closes #605
Closes #619

zakkak and others added 6 commits December 18, 2023 12:15
Prevent data races in reachability handlers registration when using
`-H:-RunReachabilityHandlersConcurrently`.

Closes oracle#5868

(cherry picked from commit 777cb82)
Don't allow null values to be passed to the `register` method of
`RuntimeJNIAccess` and `RuntimeReflection`. Since these are public APIs
GraalVM should either handle null values (by ignoring them in this case)
or throw a `NullPointerException` before creating an asynchronous task
to perform the registration in the analysis, which then results in
`NullPointerException`s being thrown later when it's no longer possible
to understand where the null value originate from.

(cherry picked from commit e6c12dd)
(cherry picked from commit d621dbd)
Not before the register methods, which can miss cases, nor later on in a runnable.

(cherry picked from commit f94551a)
Copy link
Collaborator

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Having them in different PRs would make reviewing those easier.

@jerboaa
Copy link
Collaborator

jerboaa commented Dec 18, 2023

main integration test failure is: quarkusio/quarkus#37809

@zakkak
Copy link
Collaborator Author

zakkak commented Dec 18, 2023

Seems OK. Having them in different PRs would make reviewing those easier.

Noted.

@zakkak zakkak merged commit 2c0293f into graalvm:mandrel/22.3 Dec 18, 2023
132 of 133 checks passed
@zakkak zakkak deleted the 2023-12-18-22.3-jan-cpu-backports branch December 18, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/22.3 backport OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
3 participants